Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Document that StructuredLoggingJsonMembersCustomizer implementations may optionally take constructor parameters #43314

Closed
wants to merge 1 commit into from
Closed

Document that StructuredLoggingJsonMembersCustomizer implementations may optionally take constructor parameters #43314

wants to merge 1 commit into from

Conversation

quaff
Copy link
Contributor

@quaff quaff commented Nov 28, 2024

Similar to

spring-boot/spring-boot-project/spring-boot/src/main/java/org/springframework/boot/env/EnvironmentPostProcessor.java

Lines 37 to 46 in f9aedf5

* Since Spring Boot 2.4, {@code EnvironmentPostProcessor} implementations may optionally
* take the following constructor parameters:
* <ul>
* <li>{@link DeferredLogFactory} - A factory that can be used to create loggers with
* output deferred until the application has been fully prepared (allowing the environment
* itself to configure logging levels).</li>
* <li>{@link ConfigurableBootstrapContext} - A bootstrap context that can be used to
* store objects that may be expensive to create, or need to be shared
* ({@link BootstrapContext} or {@link BootstrapRegistry} may also be used).</li>
* </ul>

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Nov 28, 2024
@wilkinsona wilkinsona added type: documentation A documentation update and removed status: waiting-for-triage An issue we've not yet triaged labels Nov 28, 2024
@wilkinsona wilkinsona added this to the 3.4.x milestone Nov 28, 2024
@wilkinsona wilkinsona self-assigned this Nov 28, 2024
@wilkinsona wilkinsona modified the milestones: 3.4.x, 3.4.1 Nov 28, 2024
wilkinsona pushed a commit that referenced this pull request Nov 28, 2024
@quaff @wilkinsona
Document StructuredLoggingJsonMembersCustomizer constructor params
34ac045 
See gh-43314
wilkinsona added a commit that referenced this pull request Nov 28, 2024
@wilkinsona
Polish "Document StructuredLoggingJsonMembersCustomizer constructor p…
15109b2 
…arams"

See gh-43314
@wilkinsona
Copy link
Member

Thanks, @quaff. I polished things a bit to match the javadoc of org.springframework.boot.logging.structured.StructuredLogFormatter in the same package.

@Netyyyy Netyyyy mentioned this pull request Dec 23, 2024
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees

@wilkinsona wilkinsona

Labels
type: documentation A documentation update
Projects
None yet
Milestone
3.4.1
Development

Successfully merging this pull request may close these issues.
3 participants
@quaff @wilkinsona @spring-projects-issues